add methods on the error types for reusability in wgsl-analyzer #1827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobhellermann
changed the title
teoxoy
approved these changes
Apr 14, 2022
jakobhellermann
added a commit
to jakobhellermann/naga
that referenced
this pull request
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I integrated naga error messages into wgsl-analyzer and in doing so made a few improvements to the error types allowing me to extract information I need.
Namely:
messageandlabelsfromfrong::wgsl::ParseErroras_inner(&self) -> &EtoWithSpan(into_inner(self) -> Ealready exists)+ ExactSizeIteratorto the label/span iterators. This is not required but nice to have when checking whether any spans exist at all withiter.len() == 0